[CHA-1610] Add support channels batch update #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelmf3
requested review from
JimmyPettersson85,
nijeesh-stream,
shaljam,
totalimmersion and
vishalnarkhede
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Layout/TrailingEmptyLines> reported by reviewdog 🐶
1 trailing blank lines detected.
Contributor
There was a problem hiding this comment.
I think you missed adding this line. This will cause NameError when calling client.channel_batch_updater
require 'stream-chat/channel_batch_updater'
it would be better if you could add some tests as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
https://linear.app/stream/issue/CHA-1610/ruby
CLA
Description of the pull request